Fix running nose with xunit. #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @gpoulin, @erikbern and @steenzout to be potential reviewers |
|
Thanks! Though there seem to be test case failure. If you can make this run on Travis too we'll definitely merge. :) (thanks for very nice PR description :)) |
|
I'll take a look ASAP Edit: Think I got it, running the ALL tests to verify with 27 and 35 |
| stderrbytes = sys.stderr.buffer | ||
| else: | ||
| stderrbytes = sys.stderr | ||
|
|
||
| if mock_target._mirror_on_stderr: | ||
| if self._write_line: | ||
| sys.stderr.write(fn + ": ") |
There was a problem hiding this comment.
Note to self: Why was this not originally not using stderrbytes?
When running nosetest with xunit, the tests would crash for external
projects using python 3.5 with something similar to:
Traceback (most recent call last):
File "./lib/python3.5/site-packages/luigi/mock.py",
line 128, in write
stderrbytes = sys.stderr.buffer
AttributeError: 'Tee' object has no attribute 'buffer'
This is becuase xunit overrides sys.stderr, and the class it uses does
not have a 'buffer' attribute.
Nose source:
https://github.com/nose-devs/nose/blob/master/nose/plugins/xunit.py#L127-L147
KyleJamesWalker
force-pushed
the
xunit-fix
branch
from
163991d
to
ab3521a
Compare
|
@Tarrasch I think this should fix it, let me know if it looks alright to you (once all the tests finish of course) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running nosetest with xunit on projects that use luigi (
nosetests tests --with-xunit), the tests would crash for external using python 3.5 with something similar to:This is because xunit overrides sys.stderr, and the class it uses does
not have the 'buffer' attribute defined.
Nose source:
https://github.com/nose-devs/nose/blob/master/nose/plugins/xunit.py#L127-L147
Motivation and Context
I can't run unit tests with xunit output, on my person projects.
Have you tested this? If so, how?
I have run the existing unit tests in test_mock.py for python 3.5 and 2.7. Also having this fix in my project passes all existing unit tests.
Note: The original commit that added this is here if needed: 21f42bc