Fix inherits decorator docs. #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @drj42, @erikbern and @steenzout to be potential reviewers |
|
Cool! LGTM |
|
@Tarrasch Is this good to be merged? Also, do you normally merge or squash? |
|
Usually squash, and also reword it. I find the practice of rewording somebody else's commit message to be a very healthy check for myself that I actually understand what I'm merging. :) However, if there are many commits, all clean and happening in a logical order that simplifies reviewing and perhaps reverting. I do a merge-commit as the value of the individual commits being merged are high. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a simple change to the description of how to use the
inheritsdecorator. I think there was a bug in the class that's supplied as the argument toclonein the example used as the motivation for theinherits.Have you tested this? If so, how?
No tests required, since it's just the docs fix.