Updated six to version 1.10.0 #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @Tarrasch to be a potential reviewer |
|
resolves #1706 |
|
There are quite a number of newline additions. Did you modify the |
|
I did not modify anything. This should be the original |
Current coverage is 76.10%@@ master #1709 diff @@
==========================================
Files 94 94
Lines 10300 10300
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8115 7838 -277
- Misses 2185 2462 +277
Partials 0 0
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated six.py from v1.9.0 to v.1.10.0
Motivation and Context
Six v.1.9.0 imports the _winreg module, which only works on Windows, and results in an ImportError when running on Linux machines. Six v.1.10.0 fixes that.
Have you tested this? If so, how?
I have run my code and it works. I was only running into problems when I tried to use the pinject library, and this fixed my ImportError