[MRG+2] Reset terminal colors in external_program ENVIRONMENT print #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @ehdr, @erikbern and @adamchainz to be potential reviewers |
Current coverage is 76.23%@@ master #1742 diff @@
==========================================
Files 95 95
Lines 10341 10342 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8161 7884 -277
- Misses 2180 2458 +278
Partials 0 0
|
|
I recuse as a reviewer, I have no idea what's happening |
|
LGTM |
|
👍 |
gte620v
changed the title
|
Thanks! :) @gte620v, oh you're affiliated with Georgia Tech! Cool, I studied abroad there a few years ago. ^^ |
|
Nice! Thanks! Go Jackets! |
p7k
pushed a commit
to Celmatix/luigi
that referenced
this pull request
Jul 11, 2016
* spotify/master: (25 commits) Version 2.2.0 Add tests for hashing parameters (spotify#1719) Update call to iteritems in luigi/tools/deps: deprecated in Python 3 (spotify#1749) Reset terminal colors in external_program (spotify#1742) Caches get_autoconfig_client on a per-thread basis Fix bug with GCSFlagTarget Add additional event handlers to tasks (spotify#1698) Reduce number of get_params calls in common_params. Removes redundant function definitions from rpc and server (spotify#1734) Fix salesforce default content type (spotify#1724) Rename MockTarget class variable _fn to path Remove MockTarget path property Deprecated LocalTarget fn propery Add note about underscore in parameter names (spotify#1729) Remove tracking url callback hack (spotify#1722) Consistent Luigi spelling in docs (spotify#1723) Update example_top_artists.rst (spotify#1662) Add combiner to docstrings in mrrunner Add luigi-deps-tree visualising tool (spotify#1680) Adding release step for Debian packages. (spotify#1718) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an
ExternalProgramRunErroris printed and there are color values in theENVIRONMENT, the terminal colors are permanently changed. I have noticed this when aPySparkTaskfails on AWS EMR. Annoyingly, in EMR, the terminal color is switched to a hard-to-read light blue.Have you tested this? If so, how?
Yeah, it is a one-line change that works fine.