Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets upstream status for BATCH_RUNNING jobs to UPSTREAM_RUNNING #1848

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

daveFNbuck
Copy link
Contributor

This was an oversight and is now fixed.

@Tarrasch Tarrasch merged commit f538d1b into spotify:master Sep 12, 2016
@Tarrasch
Copy link
Contributor

Thanks. Was the consequence a runtime crash in the scheduler?

@daveFNbuck daveFNbuck deleted the upstream_batch_running branch September 12, 2016 17:00
@daveFNbuck
Copy link
Contributor Author

I'm not sure there was a consequence to this, as we use STATUS_TO_UPSTREAM_MAP.get(dep.status, '') when retrieving from the map and UPSTREAM_RUNNING is never used anywhere. That's probably why I overlooked it in the PR even though it was in my fork. It might cause reporting scripts that use the API or a future feature to report incorrect results.

This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants