Fails batch_running tasks if worker dies early #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a worker were to die between receiving batch tasks and responding with the task that will run them, we want the tasks to fail. Our existing methods to fail batch tasks don't work in this case, so I've extended the method for failing RUNNING tasks to also work for BATCH_RUNNING in order to handle this extra case.
|
Ah, thanks for fixing this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compares task.status to both BATCH_RUNNING and RUNNING in fail_dead_worker_task instead of just to RUNNING.
Motivation and Context
If a worker were to die between receiving batch tasks and responding with the task that will run them, we want the tasks to fail. Our existing methods to fail batch tasks don't work in this case, so I've extended the method for failing RUNNING tasks to also work for BATCH_RUNNING in order to handle this extra case.
Have you tested this? If so, how?
I have included tests.