Adds time_running to batch running tasks #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but it seems that you need to rebase this :) |
We neglected to set time_running when setting a task as batch_running. By adding it, we get a better view of these tasks in the visualizer.
daveFNbuck
force-pushed
the
time_running
branch
from
0b4f598
to
16d1448
Compare
|
Done. One of the other PRs added tests starting on the same line. |
|
Thanks for the PR! :) |
|
No problem, thanks for all the merges! On Mon, Sep 12, 2016 at 7:19 PM, Arash Rouhani [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets time_running when marking a task as BATCH_RUNNING in the scheduler.
Motivation and Context
We neglected to set time_running when setting a task as batch_running. By adding it, we get a better view of these tasks in the visualizer.
Have you tested this? If so, how?
I've been using it in production, and I added a test to verify that the time is set.