Cleanup server.py file #1855
Merged
Cleanup server.py file #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That code doesn't run anymore as we've set "static_path" already. http://www.tornadoweb.org/en/branch4.4/guide/running.html#static-files-and-aggressive-file-caching
I don't know what it is, but it's been deprecated for over 1.5 years.
|
@Tarrasch, thanks for your PR! By analyzing the annotation information on this pull request, we identified @freider, @erikbern and @graingert to be potential reviewers |
|
Also, the visualiser tests still pass. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up code from server.py
Have you tested this? If so, how?
As for the StaticFileHandler, I ran the server locally and it still serves files as expected.