Uses task name instead of task_id as job identifier for MR #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much more useful to see MyTask(param=value) in the job tracker rather than MyTask_value_abf1238eb238eb1832, especially when the latter form usually removes most of the useful information for figuring out which task is which.
|
@daveFNbuck, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Tarrasch, @interskh and @mvj3 to be potential reviewers |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses task name instead of task_id as job identifier for MR
Motivation and Context
It's much more useful to see MyTask(param=value) in the job tracker rather than MyTask_value_abf1238eb238eb1832, especially when the latter form usually removes most of the useful information for figuring out which task is which. Since changing the task id format, we're no longer intending for task ids to be human-readable, and this is a context where we want something human-readable.
Have you tested this? If so, how?
I updated the unit tests and ran MRs with this code to validate that their names are now human-readable.