Add UDF support for BigQuery #1881
Conversation
|
@ukarlsson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blacker, @mikekap and @mbruggmann to be potential reviewers. |
| @@ -594,7 +600,8 @@ def run(self): | |||
| 'allowLargeResults': True, | |||
| 'createDisposition': self.create_disposition, | |||
| 'writeDisposition': self.write_disposition, | |||
| 'flattenResults': self.flatten_results | |||
| 'flattenResults': self.flatten_results, | |||
| 'userDefinedFunctionResources': [{"resourceUri": v} for v in self.udf_resource_uris] | |||
There was a problem hiding this comment.
Add a trailing comma please
There was a problem hiding this comment.
what happened to the trailing comma you added??
| @@ -567,6 +567,12 @@ def query_mode(self): | |||
| """The query mode. See :py:class:`QueryMode`.""" | |||
| return QueryMode.INTERACTIVE | |||
|
|
|||
| @property | |||
| def udf_resource_uris(self): | |||
| """List of code resource to load from a Google Cloud Storage URI (gs://bucket/path). | |||
|
I have added tests. Yes, we use this in production |
ukarlsson
force-pushed
the
master
branch
3 times, most recently
from
0f771ee
to
7d3d69a
Compare
|
@Tarrasch OK thanks have fixed the whitespacing and rebased :) |
| @@ -594,7 +600,8 @@ def run(self): | |||
| 'allowLargeResults': True, | |||
| 'createDisposition': self.create_disposition, | |||
| 'writeDisposition': self.write_disposition, | |||
| 'flattenResults': self.flatten_results | |||
| 'flattenResults': self.flatten_results, | |||
| 'userDefinedFunctionResources': [{"resourceUri": v} for v in self.udf_resource_uris] | |||
There was a problem hiding this comment.
what happened to the trailing comma you added??
|
I merge as this have had many minor iterations already. But I see that @ukarlsson actually never filled out the template in the PR. While it's indeed optional, I think you could jot down some words about why your company needed this patch. What can be done now that you couldn't do before? Thanks for the patch! :) |
No description provided.