Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make elasticsearch example run out of the box #1902

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

miku
Copy link
Contributor

@miku miku commented Oct 28, 2016

Description

Change parameters to luigi.run in elasticsearch indexing example.

Motivation and Context

The --task parameter seems obsolete now.

error: unrecognized arguments: --task

Also, I tested the example with the latest elasticsearch release 5.0.0 - it works.

Have you tested this? If so, how?

Tested locally:

$ brew install elasticsearch
$ elasticsearch --daemonize
$ python examples/elasticsearch_index.py
...
This progress looks :)

@mention-bot
Copy link

@miku, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tarrasch, @steenzout and @themalkolm to be potential reviewers.

@miku miku changed the title make elasticsearch run out of the box make elasticsearch example run out of the box Oct 28, 2016
(tested with elasticsearch 5.0.0)
@miku miku force-pushed the elasticsearch-example-run-fix branch from 7bdbc96 to 2d63927 Compare October 28, 2016 11:24
@Tarrasch Tarrasch merged commit 21f9fce into spotify:master Oct 31, 2016
@Tarrasch
Copy link
Contributor

Tarrasch commented Oct 31, 2016

An improvement so worth merging. Thanks @miku!

To improve it further, one could replace the whole code block with something like this

This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants