Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file.py: Rename to local_target.py #1915

Merged
merged 1 commit into from
Nov 9, 2016
Merged

file.py: Rename to local_target.py #1915

merged 1 commit into from
Nov 9, 2016

Conversation

Tarrasch
Copy link
Contributor

@Tarrasch Tarrasch commented Nov 7, 2016

Description

  • Rename file.py to local_target.py
  • Remove deprecated File class

@mention-bot
Copy link

@Tarrasch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @erikbern, @freider and @mikekap to be potential reviewers.

@Tarrasch Tarrasch mentioned this pull request Nov 7, 2016
Closed
dlstadther
dlstadther requested changes Nov 7, 2016
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you overlooked replacing/updating file_test.py with local_target_test.py.

miku added a commit to miku/siskin that referenced this pull request Nov 7, 2016
@miku
do not use deprecated luigi.File
7cd1bda 
prepare for: spotify/luigi#1915
@Tarrasch
file.py: Rename to local_target.py
945f611 
 * Also remove deprecated File class
@Tarrasch
Copy link
Contributor Author

Tarrasch commented Nov 8, 2016

Thanks for the catch @dlstadther, does it look good now? :)

dlstadther
dlstadther approved these changes Nov 8, 2016
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tarrasch Tarrasch merged commit 7559240 into spotify:master Nov 9, 2016
@Tarrasch Tarrasch deleted the remove_file_class branch November 9, 2016 02:07
@mcmclx mcmclx mentioned this pull request May 31, 2017
Merged
This was referenced Jun 29, 2022
Closed
Closed
@mdragilev mdragilev mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tarrasch @mention-bot @dlstadther