Sets wait_jitter in worker_test.py #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests in worker_test.py set wait_interval to 0.1 but leave wait_jitter at its default value of 5.0. This sets wait_jitter to 0.05 in all such tests, which maintains the expected 0.1 jitter time. This should reduce each wait by about 2.5 seconds, and I've found that it decreases the running time of the worker tests on my machine by about 15 seconds.
|
@daveFNbuck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @javrasya, @Tarrasch and @erikbern to be potential reviewers. |
|
Awesome catch :) |
|
Yeah, I was pretty surprised when I noticed it today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets wait_jitter to 0.05 in all workers in worker_test.py where wait_interval is set to 0.1.
Motivation and Context
Many tests in worker_test.py set wait_interval to 0.1 but leave wait_jitter at its default value of 5.0. This sets wait_jitter to 0.05 in all such tests, which maintains the expected 0.1 jitter time. This should reduce each wait by about 2.5 seconds, and I've found that it decreases the running time of the worker tests on my machine by about 15 seconds.
Have you tested this? If so, how?
I ran the tests and they're 15 seconds faster.