target_test.py: Use clean paths to avoid failures #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tarrasch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gpoulin, @steenzout and @themalkolm to be potential reviewers. |
Currently some tests will fail if you run them twice, because there's no proper cleanup done.
Tarrasch
force-pushed
the
fix-targettests
branch
from
186dfd4
to
13323dc
Compare
|
Let me know if anyone knows a more elegant way to do this. Otherwise I'll just merge this :) |
kreczko
pushed a commit
to kreczko/luigi
that referenced
this pull request
Mar 28, 2017
Currently some tests will fail if you run them twice, because there's no proper cleanup done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some tests will fail if you run them twice, because there's no
proper cleanup done. But that machinery already exists, we just need to
enable it.