Show number of unread worker messages in UI #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: luigi/static/visualiser/js/visualiserApp.js
…r_worker_communication # Conflicts: # luigi/static/visualiser/index.html
|
hm 13 commits for 10 lines of code? :) |
Tarrasch
suggested changes
Feb 4, 2017
luigi/scheduler.py
Outdated
| @@ -1328,6 +1328,7 @@ def worker_list(self, include_running=True, **kwargs): | |||
| started=worker.started, | |||
| state=worker.state, | |||
| first_task_display_name=self._first_task_display_name(worker), | |||
| unread_messages=len(worker.rpc_messages), | |||
There was a problem hiding this comment.
Call this num_unread_messages? Or even better, num_unread_rpc_messages. Would be nice if a grep-search for rpc_messages turned out all relevant bits of code for the RPC messages.
There was a problem hiding this comment.
Yep, sounds good. Done.
luigi/static/visualiser/index.html
Outdated
| #workerList .box-tools > span.label-unread-worker-messages { | ||
| margin-right: 6px; | ||
| font-style: italic; | ||
| vertical-align: middle; |
There was a problem hiding this comment.
What color do you have it in? I was thinking of maybe making it red, as it's something that under normal conditions quickly disappears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature as proposed in #1993.
In the UI, the number of unread messages per worker is shown near the top right tool box.
Changes are quite trivial and should require any additional tests =)