Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warnings in unit tests. #2078

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Conversation

kalvdans
Copy link
Contributor

This change removes some warnings that appear when running the unit tests:

luigi/luigi/file.py:26: DeprecationWarning: luigi.file module has been moved to luigi.local_target
luigi/luigi/parameter.py:259: UserWarning: Parameter 1 is not of type string.
luigi/luigi/parameter.py:259: UserWarning: Parameter 10 is not of type string.

It also allows the luigi binary to set self.complete_after to integer type, when using the --complete-after command-line flag.

@mention-bot
Copy link

@kalvdans, thanks for your PR! By analyzing the history of the files in this pull request, we identified @erikbern, @davemt and @Tarrasch to be potential reviewers.

@Tarrasch Tarrasch merged commit 5b72b4e into spotify:master Apr 5, 2017
@Tarrasch
Copy link
Contributor

Tarrasch commented Apr 5, 2017

Thanks! :)

This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants