Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Show Upstream Dependencies" in visualiser #2092

Merged
merged 2 commits into from
May 24, 2017
Merged

Conversation

xoob
Copy link
Contributor

@xoob xoob commented Apr 17, 2017

Description

Fixes the "Show Upstream Dependencies" checkbox which did not have any effect on the displayed chart.

Have you tested this? If so, how?

I tested the UI with my jobs on my local installation.

Fixes the "Show Upstream Dependencies" checkbox which did not have any effect
Copy link
Contributor

@Tarrasch Tarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I wish we had testcases for this ...

@xoob
Copy link
Contributor Author

xoob commented May 24, 2017

@Tarrasch Any chance to get this merged?

@xoob
Copy link
Contributor Author

xoob commented May 24, 2017

Related (with additional fixes): #2124

@Tarrasch Tarrasch merged commit 9284092 into spotify:master May 24, 2017
@Tarrasch
Copy link
Contributor

Sorry for leaving this hanging! Thanks for this patch! :)

@Tarrasch Tarrasch mentioned this pull request May 24, 2017
This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants