Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluos projectId parameter in BigQuery job definition #2117

Merged
merged 1 commit into from
Jun 25, 2017
Merged

Remove superfluos projectId parameter in BigQuery job definition #2117

merged 1 commit into from
Jun 25, 2017

Conversation

dmohns
Copy link
Contributor

@dmohns dmohns commented May 19, 2017

Description

Remove parameter projectId from luigi.contrib.bigquery tasks.

Motivation and Context

Have you tested this? If so, how?

I tested it using a job based on BigQueryRunQueryTask against live data.

Tarrasch
Tarrasch approved these changes May 19, 2017
View reviewed changes
Copy link
Contributor

@Tarrasch Tarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. But can you notify whoever wrote that to comment?

@dmohns
Copy link
Contributor Author

dmohns commented Jun 23, 2017

@mikekap Being the original author would you mind to review?

mikekap
mikekap approved these changes Jun 24, 2017
View reviewed changes
Copy link
Contributor

@mikekap mikekap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tarrasch Tarrasch merged commit 0b87efc into spotify:master Jun 25, 2017
This was referenced Jun 29, 2022
Closed
Closed
@mdragilev mdragilev mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarrasch Tarrasch Tarrasch approved these changes

@mikekap mikekap mikekap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmohns @mikekap @Tarrasch