Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t use cached autoconfig client in config tests #2120

Merged
merged 2 commits into from
May 21, 2017
Merged

Don’t use cached autoconfig client in config tests #2120

merged 2 commits into from
May 21, 2017

Commits on May 20, 2017

  1. Don’t use cached autoconfig client in config tests 

    In hdfs_test.ConfigurationTest, calls to hdfs.get_autoconfig_client
return the version cached in the call to setUp. Because this is called
before the config is set by the helpers.with_config decorator, this
means that the tests aren’t actually testing different configurations.

Luckily, get_autoconfig_client takes an optional argument to specify its
cache. When passing a fresh cache, these will actually test what they’re
supposed to. This PR passes a fresh cache to get_autoconfig_client in
each test.
    @daveFNbuck
    daveFNbuck committed May 20, 2017
    Configuration menu
    Copy the full SHA
    3e5e4b2 View commit details
    Browse the repository at this point in the history

  2. Skip snakebite config tests on Python 3

    @daveFNbuck
    daveFNbuck committed May 20, 2017
    Configuration menu
    Copy the full SHA
    e8e2064 View commit details
    Browse the repository at this point in the history