Serialize statuses array for URL hash #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not serializing the statuses array leads to a JSON parsing error when we try to deserialize it.
|
@daveFNbuck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nmb10, @riga and @patricksmith to be potential reviewers. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating the status hash during tab switching, use JSON to stringify the status array so it works properly.
Motivation and Context
When switching tabs away from Task List and back with statuses selected, the url hash ends up with something like
statuses=FAILEDrather thanstatuses=%5B%22FAILED%22%5D, which is the json-serialized array. This causes a json parsing error when trying to deserialize the expected json.Have you tested this? If so, how?
Switched back and forth between tabs with statuses selected. Before the change, this would always break the visualiser. After the change, it works as expected.