Allow schema to be specified for target table in sqla.CopyToTable #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
reviewed
Jul 10, 2017
luigi/contrib/sqla.py
Outdated
| ) | ||
| if not row: | ||
| self.logger.info('Creating schema {}'.format(self.schema)) | ||
| engine.execute(sqlalchemy.schema.CreateSchema(self.schema)) |
There was a problem hiding this comment.
Does a situation exist where you would intend for this to create a new schema? I can understand table creation in an existing schema, but cannot think of a case where I'd intentionally specify a schema name in my ETL for which one does not yet exist.
I worry that this may undesirably fail silently where someone has a typo in their schema name.
There was a problem hiding this comment.
Yes, it seems quite reasonable to ask users to create the schema separately to avoid this kind of silent failure. I'll remove that part and add a note.
When using an RDBMS that supports schemas, this allows target tables to exist in a non-default schema, specified using the 'schema' attribute of the task class. Closes spotify#1984.
dlstadther
approved these changes
Aug 25, 2017
|
Thanks @sd2k! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using an RDBMS that supports schemas, this allows target tables to
exist in a non-default schema, specified using the 'schema' attribute of
the task class.
Motivation and Context
See #1984.
Have you tested this? If so, how?
I have been running my jobs with this code for several months and it has worked for me.
The unit tests use SQLite which doesn't support schemas, so I haven't included any unit tests.