breaking: Remove deprecated contrib redirections #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this commit the following imports will no longer work
import luigi.s3
import luigi.postgres
Instead use
import luigi.contrib.{s3,postgres}
This is a continution on spotify#1997
|
@Tarrasch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @steenzout, @erikbern and @freider to be potential reviewers. |
dlstadther
approved these changes
Jul 12, 2017
Sounds good to me. I guess people will be more careful upgrading to a minor bump. Plus we've had many other nice contributions since last release. :) |
|
@Tarrasch Thoughts on when to merge this? (and release a new version) |
|
@Tarrasch Following up here regarding merging this PR (and maybe a few other small ones) and releasing the next large Luigi Version. Thoughts? |
|
@dlstadther totally agree, I've just been a bit lazy. Sorry about that. :) |
saku
added a commit
to saku/luigi-td
that referenced
this pull request
May 14, 2018
From luigi 2.7.0, luigi.s3 was moved to luigi.contrib.s3. https://github.com/spotify/luigi/releases/tag/2.6.0 spotify/luigi#2181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this commit the following imports will no longer work
Instead use
This is a continution on #1997
Motivation and Context
This will make it clear that these modules should not be considered core luigi.
Have you tested this? If so, how?
I ran some tox-tests locally. But I mainly rely on Travis here.