[bug-fix] scheduler won't override running status incorrectly #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
suggested changes
Jul 21, 2017
|
@Tarrasch I've added a test case for the particular fix. I'm not sure how to parse the build failure, it seems a git/build issue? Should I create a new PR? |
|
@stguido, can you rebase your code on master? This problem is fixed now but you need to rebase your code for your patch to "include" it. :) |
stguido
force-pushed
the
scheduler-status-bug-upstream
branch
from
deb4b1e
to
307aa53
Compare
stguido
force-pushed
the
scheduler-status-bug-upstream
branch
from
307aa53
to
98875bb
Compare
|
@Tarrasch, I've finally got this to be green again - lmk if it's good for a merge |
Tarrasch
approved these changes
Aug 8, 2017
|
Thanks for the fix @stguido! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The scheduler can currently override the RUNNING status of a task with something incorrect coming from a different worker other than the one currently running the task.
Motivation and Context
The issue has been discussed in the mailing list here: https://groups.google.com/forum/#!searchin/luigi-user/stefano|sort:relevance/luigi-user/WCiQfNEfWY4/5zGdX5X6BgAJ
Have you tested this? If so, how?
It passes tests. We are about to push this into our production env as well.