Support cluster mode in PySpark #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested w/ Spark 2.1
dlstadther
reviewed
Aug 2, 2017
| @@ -237,8 +237,6 @@ class PySparkTask(SparkSubmitTask): | |||
|
|
|||
| # Path to the pyspark program passed to spark-submit | |||
| app = os.path.join(os.path.dirname(__file__), 'pyspark_runner.py') | |||
| # Python only supports the client deploy mode, force it | |||
| deploy_mode = "client" | |||
There was a problem hiding this comment.
Was this an intentional deletion? Why not just allow overwrite of deploy_mode?
There was a problem hiding this comment.
deploy_mode = "client" overwrites deploy_mode in SparkSubmitTask. It was here to force deploy mode to be client since previously cluster deploy mode wasn't supported. Now that we do support it, there is no need to pin it to client only.
dlstadther
reviewed
Aug 3, 2017
|
@jthi3rry @ivannotes @ntim How do you like this PR? I tagged you here because you have contributed to pyspark class :) |
|
@dlstadther @Tarrasch I remember there used to be some bot that automatically tag ppl for reviews. What happened to it? |
|
👍 Looking forward ti try it! |
|
LGTM! |
|
Thanks @interskh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support cluster mode in PySpark
Motivation and Context
We want to use cluster mode for pyspark like spark tasks.
Have you tested this? If so, how?
We run it on production for a couple of months.