README: avoid _here_ links; ack readthedocs #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Screen reader users often navigate from link to link, skipping the text in between > > Implication 1: Links should make sense out of context. Phrases such as "click here," "more," "click for details," and so on are ambiguous when read out of context. -- http://webaim.org/techniques/hypertext/ https://www.w3.org/TR/WCAG10-HTML-TECHS/#link-text
|
Wow, I really love how you pay attention to detail and users who use screen readers here! |
|
Thanks. I've been having fun with luigi for a little while now... https://github.com/kumc-bmi/grouse/tree/master/etl_i2b2 I use that link from the README to get to the documentation pretty regularly, and it bugged me a little bit each time... and github makes it so easy to fix... so today I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://www.w3.org/TR/WCAG10-HTML-TECHS/#link-text
Have you tested this? If so, how?
I expect tweaking README text has no testing impact.