Silence Parameter type warning in WebHdfsClient #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the webhdfs configuration, the parameter `user` has the default value None, which triggers the annoying warning 'parameter.py:259: UserWarning: Parameter None is not of type string.' everytime a WebHdfsClient is created. This commit prevents this by setting the default value to ''.
|
@adaitche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tarrasch and @adamchainz to be potential reviewers. |
adaitche
changed the title
dlstadther
approved these changes
Sep 18, 2017
|
@adaitche Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Description
In the webhdfs configuration, the parameter
userhas the default value None, which triggers the annoying warningparameter.py:259: UserWarning: Parameter None is not of type string.every time a WebHdfsClient is created. This commit prevents this by setting the default value to''.Have you tested this? If so, how?
Manual testing that the warning is gone.