Hide re-enable and forgive buttons on success #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After clicking re-enable, the whole page refreshes. After clicking forgive failures, nothing happens. Both of these responses are a bit extreme. To find a happier medium, this updates both buttons to simply disappear after the response is received from the server. This makes it easier to do multiple disables and allows for more confidence in forgiving failures. This also adds the ability to hold alt with the re-enable to get an update like with forgive failures.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make re-enable and forgive failure buttons disappear on server response. Also add the ability to hold alt with the re-enable to get an update like with forgive failures. This doesn't check for whether the server was successful in its response.
Motivation and Context
After fixing a bug or system issue that causes a class of jobs to fail, I'm often left with a lot of disabled jobs that need to be re-enabled. I usually click one button and then try to quickly click as many as I can before the refresh. This process is made much slower and less reliable by all the reloads. Some of my co-workers use the javascript console to ensure they can click every available button in time.
On the other hand, I'm not even sure if I successfully clicked on the forgive failures button when I want to make a job pending again. These buttons have very similar functions but wildly different behavior. In order to make them more consistent and more reasonable, we delete them to indicate receipt of the server response.
Have you tested this? If so, how?
I tried this out on my production server and it works fine.