Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiprocessing with request sessions #2290

Merged
merged 5 commits into from
Dec 9, 2017
Merged

Handle multiprocessing with request sessions #2290

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4a4c6f
When forking with `--workers 10` requests was sharing the session, wh…
jhorman Nov 18, 2017
3d32d55
Initialize process_id to the initial pid
jhorman Nov 18, 2017
1429aa3
Adding a basic unit test
jhorman Nov 21, 2017
18751ef
Adding a message to the assert
jhorman Nov 21, 2017
4b6d1e7
Too many blank lines
jhorman Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions luigi/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
rpc.py implements the client side of it, server.py implements the server side.
See :doc:`/central_scheduler` for more info.
"""
import os
import json
import logging
import socket
Expand Down Expand Up @@ -80,8 +81,15 @@ def __init__(self, session):
from requests import exceptions as requests_exceptions
self.raises = requests_exceptions.RequestException
self.session = session
self.process_id = os.getpid()

def fetch(self, full_url, body, timeout):
# if the process id change changed from when the session was created
# a new session needs to be setup since requests isn't multiprocessing safe.
if os.getpid() != self.process_id:
self.session = requests.Session()
self.process_id = os.getpid()

resp = self.session.get(full_url, data=body, timeout=timeout)
resp.raise_for_status()
return resp.text
Expand Down