append is vulnerable of xss #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://api.jquery.com/append/ points out that `append` can introduce cross-site-scripting (XSS) vulnerabilities. In this particular case, we have identified an XSS issue as following: Spin up a Luigi instance and navigate to /static/visualiser/index.html#tab=graph&visType=svg&taskId=%3Cscript%3Ealert(1)%3C%2Fscript%3E. You should see an alert box pop up displaying 1. Use `text` instead of `append` should fix it.
|
Great job! |
|
As this is a security patch, it would better to get it out asap and somehow notify users. |
|
@honnix, you could make a new release and send an email to the user group? |
|
Yes we will do that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cross-site-scripting issue.
Motivation and Context
http://api.jquery.com/append/ points out that
appendcan introducecross-site-scripting (XSS) vulnerabilities.
In this particular case, we have identified an XSS issue as following:
Spin up a Luigi instance and navigate to /static/visualiser/index.html#tab=graph&visType=svg&taskId=%3Cscript%3Ealert(1)%3C%2Fscript%3E.
You should see an alert box pop up displaying 1.
Use
textinstead ofappendshould fix it.Have you tested this? If so, how?
I tested it locally manually.