rdbms contrib: pass connection to _add_metadata_columns #3011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method
_MetadataColumnsMixin#_add_metadata_columns
accepts a connection parameter for creating the metadata columns for theCopyToTable
task. However, the generalCopyToTable
instead sends a cursor while the redshift version sends the correct connection:luigi/luigi/contrib/redshift.py
Lines 479 to 480 in cf2abbd
Motivation and Context
Without this change you run into a AttributeError when you select
enable_metadata_columns = True
, when for example using the postgresCopyToTable
.Have you tested this? If so, how?
Ran the contrib tests.