Fix azureblob tests: use json instead of numpy #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy is not installed in the current setup
It fixes these errors:
```
File "/home/travis/build/spotify/luigi/test/contrib/azureblob_test.py", line 138, in run
import numpy
ModuleNotFoundError: No module named 'numpy'
```
https://travis-ci.org/github/spotify/luigi/jobs/754449469
The test silently failed, asserts weren't covered
Added an assert checking the output of FinalTask
vbarbaresi
requested review from
dlstadther,
honnix and
Tarrasch
as code owners
honnix
approved these changes
Feb 10, 2021
| final_task = FinalTask() | ||
| luigi.build([final_task], local_scheduler=True, log_level='NOTSET') | ||
| output = final_task.output().open("r").read() | ||
| assert "Toto" in output |
hirosassa
pushed a commit
to hirosassa/luigi
that referenced
this pull request
Feb 10, 2021
Numpy is not installed in the current setup
It fixes these errors:
```
File "/home/travis/build/spotify/luigi/test/contrib/azureblob_test.py", line 138, in run
import numpy
ModuleNotFoundError: No module named 'numpy'
```
https://travis-ci.org/github/spotify/luigi/jobs/754449469
The test silently failed, asserts weren't covered
Added an assert checking the output of FinalTask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy is not installed in the current setup.
I replaced Numpy data by a simple JSON structure
It fixes these errors (https://travis-ci.org/github/spotify/luigi/jobs/754449469):
The test silently failed, asserts didn't run because the task was skipped
I added an assert checking the output of FinalTask to make sure it runs
Tested using Azurite and using a real Azure storage account