Added support for pg8000 as the PostgreSQL driver #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narape
approved these changes
Jan 31, 2022
narape
previously approved these changes
Jan 31, 2022
dlstadther
reviewed
Mar 12, 2022
dlstadther
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the
pg8000library as the PostgreSQL driver.Motivation and Context
I'm trying to ingest data into a Gooel Cloud SQL instance without having to use
cloud_sql_proxyand found this library: https://github.com/GoogleCloudPlatform/cloud-sql-python-connector#cloud-sql-connector-for-python-drivers, however that only has support forpg8000to connect to PostgreSQL.Both
pg8000anpsycopg2implement DB API 2.0 (a.k.a. PEP-249) so most of the operation should be supported; I've just made a few changes to make sure we handle exceptions in a cross-library way.Have you tested this? If so, how?
I ran my jobs with these changes and they worked fine.