Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make task search case insensitive to match the frontend behaviour #3157

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Make task search case insensitive to match the frontend behaviour #3157

merged 2 commits into from
Apr 28, 2022

Conversation

arteymix
Copy link
Contributor

No description provided.

@arteymix
scheduler: Make task_list() search case-insensitive
f6d92af 
This matches the behaviour of the frontend.
@arteymix arteymix requested review from dlstadther and a team as code owners April 14, 2022 16:56
@dlstadther
Copy link
Collaborator

As of today, master's tests are passing again. Oddly though, Github doesn't give me the usual Update Branch button on this PR to update it and allow me to rerun unittests. Are you still using this branch and are able to merge master into it?

(I see you have another PR as well which will need the same thing).

@arteymix
Copy link
Contributor Author

You don't have the button because the branch is hosted in a different organization repository. I just updated it.

@dlstadther dlstadther merged commit 4c3f38b into spotify:master Apr 28, 2022
@arteymix arteymix deleted the task-search-case-insensitive branch May 10, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arteymix @dlstadther