Fix for applying logging configurations using the a TOML configuration file

luigi/setup_logging.py

@@ -24,6 +24,7 @@
 import os.path
 
 from luigi.configuration import get_config, LuigiConfigParser
+from luigi.freezing import recursively_unfreeze
 
 from configparser import NoSectionError
 
@@ -40,7 +41,7 @@ def _section(cls, opts):
             logging_config = cls.config['logging']
         except (TypeError, KeyError, NoSectionError):
             return False
-        logging.config.dictConfig(logging_config)
+        logging.config.dictConfig(recursively_unfreeze(logging_config))
         return True
 
     @classmethod

test/setup_logging_test.py

@@ -31,10 +31,39 @@ def test_cli(self):
         self.assertFalse(result)
 
     def test_section(self):
-        self.cls.config = {'logging': {
-            'version': 1,
-            'disable_existing_loggers': False,
-        }}
+        self.cls.config = {
+            'logging': {
+                'version': 1,
+                'disable_existing_loggers': False,
+                'formatters': {
+                    'mockformatter': {
+                        'format': '{levelname}: {message}',
+                        'style': '{',
+                        'datefmt': '%Y-%m-%d %H:%M:%S',
+                    },
+                },
+                'handlers': {
+                    'mockhandler': {
+                        'class': 'logging.StreamHandler',
+                        'level': 'INFO',
+                        'formatter': 'mockformatter',
+                    },
+                },
+                'loggers': {
+                    'mocklogger': {
+                        'handlers': ('mockhandler',),
+                        'level': 'INFO',
+                        'disabled': False,
+                        'propagate': False,
+                    },
+                },
+            },
+        }
+        result = self.cls._section(None)
+        self.assertTrue(result)
+
+        self.cls.config = LuigiTomlParser()
+        self.cls.config.read(['./test/testconfig/luigi_logging.toml'])
         result = self.cls._section(None)
         self.assertTrue(result)
 

test/testconfig/luigi_logging.toml

@@ -0,0 +1,18 @@
+[logging]
+version = 1
+disable_existing_loggers = false
+
+[logging.formatters.mockformatter]
+format = "{levelname}: {message}"
+style = "{"
+
+[logging.handlers.mockhandler]
+class = "logging.StreamHandler"
+level = "INFO"
+formatter = "mockformatter"
+
+[logging.loggers.mocklogger]
+handlers = ["mockhandler"]
+level = 'INFO'
+disabled = false
+propagate = false