Fix compatibility with cythonized tasks. #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`types.GeneratorType` is not compatible with the generator type of Cython. This leads to `_run_get_new_deps()` returning directly when the task is from a cythonized module and [yields dynamic dependencies](https://luigi.readthedocs.io/en/stable/tasks.html?highlight=yield#dynamic-dependencies).
dlstadther
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
types.GeneratorTypeis not compatible with the generator type of Cython. This leads to_run_get_new_deps()returning directly when the task is from a cythonized module and yields dynamic dependencies.Motivation and Context
We have cythonized modules with luigi tasks and noticed that the tasks immediately switch to DONE without doing anything, without logging any error or having any task output.
Have you tested this? If so, how?
I successfully ran cythonized and non-cythonized tasks with this patch.
Side note: I originally wanted to use
typing.Generator, but this now deprecated.There were also no other uses of
typesin the code base.