Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dropbox.py for compatibility with Dropbox SDK v11.X.X #3259

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

smrohrer
Copy link
Contributor

dropbox.dropbox has been renamed to dropbox.dropbox_client

https://github.com/dropbox/dropbox-sdk-python/blob/main/UPGRADING.md

@smrohrer smrohrer requested review from dlstadther and a team as code owners October 22, 2023 15:56
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on changing

luigi/tox.ini

Line 62 in d86b97e

dropbox: dropbox>=9.3.0<10.0
to be for v11.x.x?

@smrohrer
Copy link
Contributor Author

Thank you for the quick response! The tests are passing for me locally with tox -e py37-dropbox

Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlstadther dlstadther merged commit fe7ecf4 into spotify:master Oct 25, 2023
37 of 38 checks passed
@smrohrer smrohrer deleted the patch-1 branch October 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants