Support Python3.12 #3266
Merged
Support Python3.12 #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
reviewed
Dec 21, 2023
| @@ -107,6 +108,7 @@ def test_read_no_file_sse(self): | |||
| t = self.create_target(encrypt_key=True) | |||
| self.assertRaises(FileNotFoundException, t.open) | |||
|
|
|||
| @unittest.skipIf(tuple(sys.version_info) >= (3, 12), "boto is not supported on Python 3.12+") | |||
There was a problem hiding this comment.
I think the better thing to do here would be to make the s3 module compatible with boto3
There was a problem hiding this comment.
Can the s3 module be improved in another PR? Ubuntu 24 came out with Python 3.12 as default, and the lack of support in Luigi will block updates for many users (although fortunately, the changes only affect tests, so it's not critical).
There was a problem hiding this comment.
Given the need for 3.12 Luigi support, i'm ok getting this PR out the door.
@ukky17 , if you can resolve the merge conflict, i can merge if tests still pass.
There was a problem hiding this comment.
@dlstadther I have resolved the conflict. Please review again and merge if it looks good to you.
dlstadther
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
boto, becausebotois not compatible with Python 3.12.botois an old package ofboto3and is no longer maintained.assertEquals,assertNotEquals, andassertAlmostEqualsare replaced, which have been deprecated since Python 3.1 and are removed in Python 3.12.Motivation and Context
Support Python 3.12
Have you tested this? If so, how?
All CI tests have passed.