Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated luigi.contrib.azureblob to 12.x.y series of azure.storage.blob #3290

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Updated luigi.contrib.azureblob to 12.x.y series of azure.storage.blob #3290

merged 4 commits into from
Jul 13, 2024

Conversation

bcamel
Copy link
Contributor

@bcamel bcamel commented May 19, 2024

Description

Updated luigi.contrib.azureblob to adhere to API changes in the Azure Storage Blobs client library for Python.

Related changes:

  • Updated the CI script to start an Azurite service via Docker. Uses the official image mcr.microsoft.com/azure-storage/azurite
  • Updated the related environment variables in the unit test runner to be able to connect to the local Azurite instance.

Motivation and Context

This PR addresses issue #2965.

Have you tested this? If so, how?

  • Ran the GitHub Actions including the matrix items pyXYZ-azureblob.
  • Extended test case to cover the mkdir function of AzureBlobClient

@bcamel bcamel requested review from dlstadther and a team as code owners May 19, 2024 16:37
dlstadther
dlstadther reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, otherwise, once CI tests pass, i'm good here.

tox.ini Outdated Show resolved Hide resolved
@dlstadther dlstadther merged commit 2418cdf into spotify:master Jul 13, 2024
48 checks passed
@bcamel bcamel deleted the issue-2965-update-azure-storage branch July 14, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcamel @dlstadther @andresgomezfrr