Replace pipes.quote with shlex.quote #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `shlex.quote()` API is available from Python 3.3 on; `pipes.quote()` was never documented, and is removed in Python 3.13.
dlstadther
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
pipes.quote() was documented in the Python 2.7 docs with the note
Deprecated since version 2.7: Prior to Python 2.7, this function was not publicly documented. It is finally exposed publicly in Python 3.3 as the quote function in the shlex module.
So even though shlex.quote comes with the warning Warning The shlex module is only designed for Unix shells., given that it is equivalent to pipes.quote, this should have no change of behavior. (also shlex.quote was added in Python 3.3 and Luigi only "officially" supports 3.6+, we're still good here).
Thanks for this contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
shlex.quote()API is available from Python 3.3 on;pipes.quote()was never documented, and is removed in Python 3.13.Motivation and Context
Support Python 3.13