Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when running spreadsheet importer in Fiori elements with multiple tabs #579

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

lemaiwo
Copy link
Contributor

@lemaiwo lemaiwo commented Jun 18, 2024

Hi @marianfoo ,
The upload dialog doesn't close correctly when using the cancel button. It disappears but still blocks the navigation in the fiori elements app. This fixes the problem.

Tested on version 1.96.32

Additional solution could be to provide an event handler to handle the cancel event ourself.

Kr, Wouter

@marianfoo
Copy link
Member

I have not yet had this problem directly.
It sometimes happened during the test, but I couldn't recreate it locally, but that could be the reason.
Tests are green so I will merge it and publish it right away.
Thank you!

@marianfoo marianfoo merged commit 5a0b05d into spreadsheetimporter:main Jun 18, 2024
27 checks passed
@marianfoo marianfoo mentioned this pull request Jun 18, 2024
@marianfoo
Copy link
Member

Fix published with version 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants