fix: define types versions covering all import options #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
typesVersions
property topackage.json
files ofstorefront sdk
andplatform sdk
that points to the same type definitions for all/dist/...
imports.Before, only importing the sdks by name included type definitions:
While specifying an explicit path didn't, resulting in a "Cannot find module ... or its corresponding type declarations" error:
This issue was also present in
v5.1.6
of the storefront sdk (before we started splitting up the project into multiple packages).