Fix Promotions#index view when a promotion has expires_at set #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdonarski
force-pushed
the
fix/promotion_expires_at_in_admin_panel
branch
from
8219343
to
9dac555
Compare
tomdonarski
force-pushed
the
fix/promotion_expires_at_in_admin_panel
branch
from
9dac555
to
6681fad
Compare
rafalcymerys
requested changes
Jan 9, 2024
| @@ -64,7 +64,7 @@ | |||
| <td><%= promotion.description %></td> | |||
| <td><%= promotion.usage_limit.nil? ? "∞" : promotion.usage_limit %></td> | |||
| <td><%= Spree.t(:current_promotion_usage, count: promotion.credits_count) %></td> | |||
| <td><%= promotion.expires_at.to_date.to_s(:short_date) if promotion.expires_at %></td> | |||
There was a problem hiding this comment.
This will change the format of the date, which I don't think is intended.
The issue is caused by Rails 7.1 having removed to_s in favor of to_fs. Since we'd like to support Rails 6.1+, I think it would be best to use strftime instead (just like some other places in the codebase do)
rafalcymerys
approved these changes
Jan 16, 2024
delete-merged-branch
bot
deleted the
fix/promotion_expires_at_in_admin_panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix Promotions#index view when a promotion has
expires_atset.https://upsidelab.atlassian.net/browse/SP-178
Why?
Promotion#index view breaks due to an
ArgumentError:(wrong number of arguments (given 1, expected 0) (ArgumentError))How?
Deletion of unnecessary conversion to String (along with faulty argument passing).