Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

SAMLProcessingFilter does not respect AuthenticationDetailsSource #466

Open
dellekappa opened this issue Nov 15, 2019 · 0 comments
Open

Comments

@dellekappa
Copy link

SAMLProcessingFilter, like any other filters extending AbstractAuthenticationProcessingFilter, should respect what has been setted with setAuthenticationDetailsSource.

The value in this.authenticationDetailsSource is completely ignored by this filter.
Furthermore, SAMLAuthenticationProvider drops the authenticationDetails information provided within the Authentication argument in the authenticate method, setting the details of the returned Authentication object with userDetails variable value, but this value is already retrievable by calling getPrincipal on the returned Authentication.

dellekappa pushed a commit to dellekappa/spring-security-saml that referenced this issue Nov 15, 2019
dellekappa pushed a commit to dellekappa/spring-security-saml that referenced this issue Nov 15, 2019
dellekappa pushed a commit to dellekappa/spring-security-saml that referenced this issue Nov 15, 2019
Fixed line separator issue
dellekappa pushed a commit to dellekappa/spring-security-saml that referenced this issue Nov 15, 2019
Fixed line separator issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant