Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for profile specific config data loading #2260

Merged
merged 1 commit into from
May 4, 2023

Conversation

ryanjbaxter
Copy link
Contributor

@fragaLY
Copy link

fragaLY commented May 30, 2023

@ryanjbaxter, If the 'property' source doesn't contain "/" and doesn't contain the "." - the name will be "onfigClient" not "configClient".

Moreover, extractApplicationName throwing the "java.lang.StringIndexOutOfBoundsException: begin 147, end 111, length 162" for case propertySource.getName() == "configserver:Config resource 'file [../configs/location-service/location-service.yml]' via location '../configs/location-service/' (document #0)"

Well done.

@ryanjbaxter
Copy link
Contributor Author

@fragaLY if you have found an but please open a separate issue and provide a sample to reproduce it and I will happily fix the problem

@VitaliyKulikov
Copy link

VitaliyKulikov commented Jun 8, 2023

@ryanjbaxter, If the 'property' source doesn't contain "/" and doesn't contain the "." - the name will be "onfigClient" not "configClient".

Moreover, extractApplicationName throwing the "java.lang.StringIndexOutOfBoundsException: begin 147, end 111, length 162" for case propertySource.getName() == "configserver:Config resource 'file [../configs/location-service/location-service.yml]' via location '../configs/location-service/' (document #0)"

Well done.

same here

Caused by: java.lang.StringIndexOutOfBoundsException: begin 183, end 153, length 198
        at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4602) ~[na:na]
        at java.base/java.lang.String.substring(String.java:2705) ~[na:na]
        at org.springframework.cloud.config.client.ConfigServerConfigDataLoader.extractApplicationName(ConfigServerConfigDataLoader.java:223) ~[spring-cloud-config-client-4.0.3.jar:4.0.3]
        at org.springframework.cloud.config.client.ConfigServerConfigDataLoader.isProfileSpecificPropertySource(ConfigServerConfigDataLoader.java:207) ~[spring-cloud-config-client-4.0.3.jar:4.0.3]
        at org.springframework.cloud.config.client.ConfigServerConfigDataLoader.lambda$doLoad$1(ConfigServerConfigDataLoader.java:160) ~[spring-cloud-config-client-4.0.3.jar:4.0.3]

@ryanjbaxter
Copy link
Contributor Author

@VitaliyKulikov can you open a separate issue with a sample that reproduces the problem?

@VitaliyKulikov
Copy link

@ryanjbaxter u r wlcm ) #2279

@ryanjbaxter
Copy link
Contributor Author

@VitaliyKulikov thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigClient not honoring spring.profiles.active from config server
5 participants