(4.0.x) Enhance "/actuator/gateway" endpoint #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We shouldnt really need a separate PR for main, so I think we can close #3148 and just merge this one forward. |
ryanjbaxter
requested changes
Dec 5, 2023
| @@ -88,6 +100,53 @@ public AbstractGatewayControllerEndpoint(RouteDefinitionLocator routeDefinitionL | |||
| this.routeLocator = routeLocator; | |||
| } | |||
|
|
|||
| private List<GatewayEndpointInfo> getAvailableEndpointsForClass(String className) { | |||
| try { | |||
| MetadataReader metadataReader = new SimpleMetadataReaderFactory().getMetadataReader(className); | |||
There was a problem hiding this comment.
We don't need to instantiate SimpleMetadataReaderFactory every time this method is called
| @@ -61,6 +71,8 @@ public class AbstractGatewayControllerEndpoint implements ApplicationEventPublis | |||
|
|
|||
| private static final Log log = LogFactory.getLog(GatewayControllerEndpoint.class); | |||
|
|
|||
| private static final String ENDPOINT_PREFIX = "/actuator/gateway"; | |||
There was a problem hiding this comment.
Actuator endpoints won't necessarily be at /actuator. What happens if they are configured to be at a different endpoint?
There was a problem hiding this comment.
| testClient.get().uri("http://localhost:" + port + "/actuator/gateway").exchange().expectStatus().isOk() | ||
| .expectBody(List.class).consumeWith(result -> { | ||
| List<String> responseBody = result.getResponseBody(); | ||
| assertThat(responseBody).isNotEmpty(); |
There was a problem hiding this comment.
It would be good to validate that we are getting all the endpoints we expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #3128