Fix 1278 #1280
Fix 1278 #1280
Conversation
Configure Renovate
| @@ -29,6 +32,7 @@ | |||
| @Configuration(proxyBeanMethods = false) | |||
| @ConditionalOnProperty("spring.cloud.config.discovery.enabled") | |||
| @Import({ Fabric8AutoConfiguration.class, KubernetesDiscoveryClientAutoConfiguration.class }) | |||
| @EnableConfigurationProperties({ KubernetesDiscoveryProperties.class, KubernetesClientProperties.class }) | |||
There was a problem hiding this comment.
this is the core problem right here. this bootstrap imports two configurations:
Fabric8AutoConfiguration, which internally requiresKubernetesClientPropertiesKubernetesDiscoveryClientAutoConfigurationwhich internally requiresKubernetesDiscoveryProperties
These work just fine on their own if used by auto-configuration only, but once we use bootstrap annotations like @AutoConfigureBefore break.
The one change that I did not account for was the fact that before this change, we used to provide an explicit KubernetesDiscoveryProperties @Bean and I dropped it once I fixed that issue. Totally my mistake here.
The other one with KubernetesClientProperties was still present, but as said in the issue itself, we got very lucky that no one actually stepped on it.
It's kind of sad that I spent so much time thinking into not breaking anything once I make my changes, and it still happens...
| @@ -0,0 +1,16 @@ | |||
| spring: | |||
There was a problem hiding this comment.
I've added an integration test with bootstrap enabled, that should catch these kind of things in the future.
|
@ryanjbaxter ready to be looked at. thank you. |
No description provided.