Increase timeout for integration tests #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure Renovate
wind57
commented
Apr 4, 2023
| @@ -455,7 +455,7 @@ private String secretName(V1Secret secret) { | |||
|
|
|||
| private void waitForDeployment(String namespace, V1Deployment deployment) { | |||
| String deploymentName = deploymentName(deployment); | |||
| await().pollInterval(Duration.ofSeconds(1)).atMost(600, TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
This is needed mainly because of the ActuatorRefreshRabbitMQIT - which is a very slow test. Locally, in my Mac M1, it takes around 4 minutes to run. But on github, not even 10 is enough. As such, increase it to 900 seconds.
|
@ryanjbaxter this small PR will fix the existing build. thank you for looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.