Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove k8s client spring integration dependency #1288

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Apr 7, 2023

No description provided.

wind57 and others added 30 commits December 4, 2021 07:59
@@ -24,10 +24,6 @@
<groupId>io.kubernetes</groupId>
<artifactId>client-java-extended</artifactId>
</dependency>
<dependency>
Copy link
Contributor Author

@wind57 wind57 Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an easy fix that took almost a day to figure out. :) While working on a different thing (add support for selective namespaces in discovery k8s-client), I wrote some integration tests that were constantly failing. After investigation, I realized that some beans that we create, for example:

	@Bean
	@ConditionalOnMissingBean
	public SharedInformerFactory sharedInformerFactory(ApiClient client) {
		return new SharedInformerFactory(client);
	}

were never created by us, but were coming from this maven dependency.

We do not require it anymore, since we don't use anything from it (the vast majority of things that we were using were deprecated inside it and we refactored our code in a different PR anyway).

As such, currently, we do not depend on anything from this maven dependency, instead it just clutters our spring context (and breaks some integration tests that I was working on)

@wind57 wind57 marked this pull request as ready for review April 7, 2023 23:54
@wind57 wind57 marked this pull request as draft April 8, 2023 13:54
@wind57 wind57 marked this pull request as ready for review April 8, 2023 14:32
@ryanjbaxter ryanjbaxter added this to the 3.0.3 milestone Apr 10, 2023
@ryanjbaxter ryanjbaxter merged commit d6ac19e into spring-cloud:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants