Fix properties retrieval order from configmaps #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess some tests would nice to have here... |
wind57
reviewed
Apr 7, 2023
| eq(null), eq(null), eq(null), eq(null))).thenReturn(CONFIGMAP_DEV_LIST); | ||
| KubernetesEnvironmentRepository environmentRepository = new KubernetesEnvironmentRepository(coreApi, | ||
| kubernetesPropertySourceSuppliers, "default"); | ||
| Environment environment = environmentRepository.findOne("stores-dev", "", ""); |
There was a problem hiding this comment.
I'm not sure I agree with this test. Don't you need to assert order here? Cause right now you are asserting only for presence.
There was a problem hiding this comment.
I can change the test checking that the last configmap on the list is "application" but what I want with this test is to allow to override the properties in "application" configmap with properties in more specific configmaps.
So without the fix this test fails because the fist configmap retrieved is the "application" configmap.
There was a problem hiding this comment.
ah! indeed, that makes sense.
The properties defined by the configmap "application" should be the last in the environment list, so you can always override the properties values by profile and by application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties defined by the configmap "application" should be the last in the environment list, so you can always override the properties values by profile and by application