Fix paths documentation #1330
Merged
Fix paths documentation #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure Renovate
wind57
commented
Apr 30, 2023
| @@ -583,9 +583,17 @@ Another option for using `ConfigMap` instances is to mount them into the Pod by | |||
| and having Spring Cloud Kubernetes read them from the file system. | |||
| This behavior is controlled by the `spring.cloud.kubernetes.config.paths` property. You can use it in | |||
| addition to or instead of the mechanism described earlier. | |||
| You can specify multiple (exact) file paths in `spring.cloud.kubernetes.config.paths` by using the `,` delimiter. | |||
There was a problem hiding this comment.
The problem is in this sentence:
You can specify multiple (exact) file paths in
spring.cloud.kubernetes.config.pathsby using the,delimiter.
It was probably left in the documentation from an older implementation, because right now, this is expected to be a List<String>:
@ConfigurationProperties(ConfigMapConfigProperties.PREFIX)
public record ConfigMapConfigProperties(....@DefaultValue List<String> paths, ...
You can look in ConfigMapPropertySourceLocator::addPropertySourcesFromPaths also, if needed.
|
@ryanjbaxter minor thing that resulted of a bug investigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.